refactor: deprecate options possibly being null
#2387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2387 +/- ##
==========================================
+ Coverage 89.48% 89.50% +0.02%
==========================================
Files 78 78
Lines 2890 2896 +6
==========================================
+ Hits 2586 2592 +6
Misses 304 304 ☔ View full report in Codecov by Sentry. |
DjordyKoert
added a commit
that referenced
this pull request
Nov 8, 2024
## Description Deprecates `options` nullable type for `Model` classes. This reduces complexity and streamlines it with the `$serializationContext`. ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [x] Refactor - [x] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [x] I have made corresponding changes to the changelog (`CHANGELOG.md`) (cherry picked from commit c431718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecates
optionsnullable type forModelclasses. This reduces complexity and streamlines it with the$serializationContext.What type of PR is this? (check all applicable)
Checklist
docs/)CHANGELOG.md)